-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate serve command line options in favor of yaml config file #146
Comments
@Deegue Please list the options to keep and options to remove here. |
As for serve.py, I'm going to remove:
while those configs are still kept in command line options: |
@Deegue thanks for the summary. I am ok with this except @KepingYan pls clarify the differences between simple and OpenAI when using --route_prefix, could we just put it in the yaml file? |
Now we support three modes to pass parameters:
If we remove these parameters, what will determine the other attribute values when user specifies
|
Can we keep 1 and 3 and remove 2? @Deegue Keep in mind that We need to serve multiple models at the same time. So also need to support multiple config files |
Obviously, it will be clear if we remove case 2.. |
Yes, pls go ahead to remove case 2 and update code & docs |
also rename --model_id_or_path to --model_id |
If we remove case 2, can we also remove --model_id_or_path and --tokenizer_id_or_path? Just use --models to specify the list of models to deploy? |
We will put most of the complex config in yaml file.
Only keep some necessary options and remove command line options already presented in yaml file to avoid confusing.
The text was updated successfully, but these errors were encountered: