Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override config file with command line argument #98

Closed
xwu99 opened this issue Feb 4, 2024 · 2 comments
Closed

Override config file with command line argument #98

xwu99 opened this issue Feb 4, 2024 · 2 comments

Comments

@xwu99
Copy link
Contributor

xwu99 commented Feb 4, 2024

Currently we override parameter from config file over command line,
However, in normal sense, command line argument should override config file to provide flexibility when executing command line.

@carsonwang @KepingYan @jiafuzha
@xwu99
Copy link
Contributor Author

xwu99 commented Feb 28, 2024

there are 2 points to fix this confusion:

  1. print a message to say command line specified both config file and other params, config file take precedence.
  2. add --verbose flag to print out the effective params to allow user to examine what is running.

cheehook pushed a commit to JoshuaL3000/llm-on-ray that referenced this issue Mar 8, 2024
@xwu99
Fix deepspeed streaming_generate (intel#98)
a05e759 
* Fix deepspeed streaming_generate

* add dummy streamer

* nit

* nit

* add --streaming_response to CI

* rewrite DummyStreamer

Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>

* nit

Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>

* update

Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>

* update

Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>

* disable mpt

---------

Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>
@xwu99
Copy link
Contributor Author

xwu99 commented Mar 15, 2024 •
edited
Loading

close this and check #146.

@xwu99 xwu99 closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xwu99