Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI formatting job appears to be broken #14737

Closed
steffenlarsen opened this issue Jul 24, 2024 · 1 comment · Fixed by #14999
Closed

CI formatting job appears to be broken #14737

steffenlarsen opened this issue Jul 24, 2024 · 1 comment · Fixed by #14999
Labels
bug Something isn't working confirmed

Comments

@steffenlarsen
Copy link
Contributor

Describe the bug

The clang-formatter CI pass does not seem to correctly identify formatting errors. This is illustrated with #14600.

To reproduce

  1. Include a code snippet that is as short as possible
  2. Specify the command which should be used to compile the program
  3. Specify the command which should be used to launch the program
  4. Indicate what is wrong and what was expected

Environment

  • OS: [e.g Windows/Linux]
  • Target device and vendor: [e.g. Intel GPU]
  • DPC++ version: [e.g. commit hash or output of clang++ --version]
  • Dependencies version: [e.g. the output of sycl-ls --verbose]

Additional context

No response
@steffenlarsen steffenlarsen added the bug Something isn't working label Jul 24, 2024
@uditagarwal97
Copy link
Contributor

The bug seems to be introduced by LLVM trunk: llvm/llvm-project@9572388
I guess we'd have to cherry-pick the fix: llvm/llvm-project#98227

@uditagarwal97 uditagarwal97 mentioned this issue Aug 7, 2024
Merged
sarnex pushed a commit that referenced this issue Aug 7, 2024
@uditagarwal97 @boomanaiden154 @ldionne
[CI] Fix code formatting workflow (#14999)
cec1423 
The code formatting workflow broke just before pulldown from LLVM trunk.
This PR cherry-picks the relevant commits from LLVM trunk to fix the
bug:
llvm/llvm-project@b3c450d
and
llvm/llvm-project@9572388

Example run: #14998
Fixes #14737

---------

Co-authored-by: Aiden Grossman <aidengrossman@google.com>
Co-authored-by: Louis Dionne <ldionne.2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Fix code formatting workflow intel/llvm
3 participants
@uditagarwal97 @steffenlarsen @lbushi25