-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsycl-targets ordering interfere with cuda-gpu-arch flag #3699
Comments
Tagging @AGindinson @mdtoguchi and @steffenlarsen |
@Ralender is this the same bug you are working on with Nvidia GPU + Xilinx FPGA in https://github.com/triSYCL/sycl ? |
I dodged this issue via: Action::OffloadKind DeviceOffloadingKind) const {
HostTC.addClangTargetOptions(DriverArgs, CC1Args, DeviceOffloadingKind);
- StringRef GpuArch = DriverArgs.getLastArgValue(options::OPT_march_EQ);
+ StringRef GpuArch = DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_50");
assert(!GpuArch.empty() && "Must have an explicit GPU arch.");
assert((DeviceOffloadingKind == Action::OFK_OpenMP ||
DeviceOffloadingKind == Action::OFK_SYCL || but this is more a way to bypass the issue than to fix it as it will also affect the cuda workflow. |
@dosarudaniel I believe this is a duplicate of #3631 which has now been resolved. Can you test if the error still occurs with the most recent build? Many Thanks. BTW: I accidentality closed this, then reopened it. Just a miss click, I apologize if there was any confusion |
We believe this issue is resolved now, addressed by #4673 so we are closing this ticket. If you are sill seeing any issues with this please leave a comment and we can re-open it. |
Description
When I am trying to compile this sample code (
make test12
) , with this CMakelist filewhich contains these flags:
I get this error :
const: Assertion !GpuArch.empty() && "Must have an explicit GPU arch."' failed.
If I swap the fsycl-targets (to
fsycl-targets=spir64_x86_64-unknown-unknown-sycldevice,nvptx64-nvidia-cuda-sycldevice
) I do not have this.I need to use the
"--cuda-gpu-arch=sm_61"
flag because some of my libraries were compiled for this arch.Details:
It might be related to this bug as well.
Environment:
OS: Ubuntu 18.04.5 LTS
Target device and vendor: NVIDIA GPU: GeForce RTX 2080 SUPER
DPC++ version: clang version 13.0.0 (https://github.com/intel/llvm c2d6cfa)
The text was updated successfully, but these errors were encountered: