[SYCL] Fix EnableIfOutputIteratorT trait #12834
Conversation
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sycl/include/sycl/buffer.hpp
Outdated
| static_assert(!std::is_const_v<std::remove_reference_t<decltype(*FinalData)>>, | ||
| "set_final_data must be called with a non-const iterator!"); |
There was a problem hiding this comment.
Why this and not the fix in EnableIfOutputIteratorT?
There was a problem hiding this comment.
My reasoning was that by adding it to EnableIfOutputIteratorT, when we call set_final_data_internal with a const iterator it simply gets ignored by overload resolution and the compiler diagnostics will most likely be confusing for someone who is not that familiar with template errors. Furthermore, this is an easy mistake to make when writing SYCL code and therefore it would be nice to get a clear error message telling you what you did wrong and thats what a static_assert does. If you're not convinced however, I can add it to EnableIfOutputIteratorT.
There was a problem hiding this comment.
it simply gets ignored by overload resolution
And that's what the spec says should happen, isn't it?
There was a problem hiding this comment.
Can you provide the part of the spec that says this?
All I can see is that the spec says what to do if the iterator is not const, I cant see anything regarding what to do if it is const.
There was a problem hiding this comment.
SYCL:
Destination can be either an output iterator or a std::weak_ptr.
C++:
The output_iterator concept is a refinement of input_or_output_iterator, adding the requirement that it can be used to write values of type and value category encoded by T (via indirectly_writable). equality_comparable is not required.
There was a problem hiding this comment.
I see, thanks for the clarification!
I will make the suggested changes!
lbushi25
changed the title
|
@aelovikov-intel ping |
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sycl/include/sycl/detail/common.hpp
Outdated
| @@ -35,7 +35,9 @@ using EnableIfOutputPointerT = std::enable_if_t< | |||
|
|
|||
| template <typename DataT> | |||
| using EnableIfOutputIteratorT = std::enable_if_t< | |||
| /*is_output_iterator<DataT>::value &&*/ !std::is_pointer_v<DataT>>; | |||
| /*is_output_iterator<DataT>::value &&*/ !std::is_pointer_v<DataT> && | |||
| !std::is_const_v<std::remove_reference_t< | |||
There was a problem hiding this comment.
- Line 34 has the same bug.
- Have you checked if comment at line 30 is up-to-date?
There was a problem hiding this comment.
I will check if its prossible to uncomment the is_output_iterator trait then I'll get back to you. If this is unblocked then this PR is done.
There was a problem hiding this comment.
@aelovikov-intel It looks like the problem was with void* ptr so I added a full specialization for that case. This enabled me to uncomment the is_output_iterator. Let me know of any concerns!
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
changed the title
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
There is some confusion going on. The test test-e2e/Basic/buffer/buffer.cpp is calling |
My opinion here is that the test was wrong, but we didn't catch it because the specification was ambiguous. If we clarify the specification, we can update the test. But I'd like to hear from @gmlueck. |
I agree. The type Note that there are other potential breaking changes being discussed in KhronosGroup/SYCL-CTS#877, so it might make sense to wait for that to resolve and make all the changes at once. |
This PR fixes the implementation of the
EnableIfOutputIteratorTtype trait that is used in the overloads of the set_final_data_internal method of the buffer class. This makes it so that set_final_data will be disabled if its argument is a non-modifiable iterator/pointer.