-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][thinLTO] Don't pass -properties and -ir-output-only to sycl-post-link #14501
Conversation
…st-link Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
if (OutputType == types::TY_LLVM_BC) { | ||
// single file output requested - this means only perform necessary IR | ||
// transformations (like specialization constant intrinsic lowering) and | ||
// output LLVMIR | ||
addArgs(PostLinkArgs, TCArgs, {"-ir-output-only"}); | ||
} else if (!IsUsingLTO || LTOMode != LTOK_Thin) { | ||
addArgs(PostLinkArgs, TCArgs, {"-properties"}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment explaining why -properties can't be used along with -ir-output-only? Looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thx!
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@asudarsa Ping on this one? This is causing some internal test failures. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
@intel/llvm-gatekeepers Ready to merge. Thanks |
@asudarsa Thanks so much! |
This errors out anyway, so it was just wrong.