[SYCL][E2E] Fix warnings from using GNU style options with MSVC compiler driver #15364
+57
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayylol
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
ayylol
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Should we fix the driver instead of ignoring the warning? @intel/dpcpp-clang-driver-reviewers, FYI. |
ayylol
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
The failure on gen12 Linux is unrelated to the changes in this pr. Reported in #15341 |
againull
approved these changes
Sep 11, 2024
| @@ -6,5 +6,5 @@ | |||
| // RUN: %{run} %t.out | |||
|
|
|||
| // Test -O0 with `--offload-new-driver` | |||
| // RUN: %clangxx -O0 -fsycl -fsycl-targets=spir64-x86_64 %S/Inputs/aot.cpp | |||
| // RUN: %clangxx %no_opt -fsycl -fsycl-targets=spir64-x86_64 %S/Inputs/aot.cpp | |||
There was a problem hiding this comment.
I think that %O0 would be a better name for this substitution.
The thing is that we have two different methods of disabling optimizations and no_opt is a bit confusing:
- We have
-O0which disables both optimizations made by SYCL compiler and also records some metadata into device images which later leads to backend optimizations also being disabled - We also have
-fno-sycl-early-optimizations, which only disables optimizations made by SYCL compiler, but preserves optimizations made by device compilers later
Even though optimization pipeline is very similar (if not the same) for both options, resulting LLVM IR will differ between them. -O0 will have optnone attached to functions, whilst -fno-sycl-early-optimizations won't result in such attribute
againull
pushed a commit
that referenced
this pull request
Sep 23, 2024
Changes the `%no_opt` expansion introduced in #15364, to `%O0` to reduce confusion in between different methods of disabling optimizations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the addition of the
-Werrorflag, these warnings were causing test failures when compiling tests with clang-cl. This patch does the following:-Wno-unused-command-line-argumentto linking run lines. This is needed because when testing the MSVC driver the/EHscflag is added to all run lines that call the compiler. This flag however is only needed at the compile stage so it is reported as unused if a run line is only linking.%no_opt, which is either-O0or/Oddepending on the compiler driver.%cxx_std_optionin place of-std=/clang:to the flag when using MSVC driver.