This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
Wayland input review #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces WaylandPointer class. The main responsibility of this class is to implement wl_pointer_listener interface and dispatch appropriate events to Ozone message loop. In future, it should support touch. The main consumer of this class would be input_device.
The patch introduces WaylandKeyboard class. The main responsibility of this class is to implement wl_keyboard_listener interface and dispatch appropriate events to Ozone message loop. The main consumer of this class is input_device
classes. Currently, input_device is responsible for handling pointer and keyboard related activity. Also, in future it would need to support touch, selection logic, drag and drop etc. The main idea with this change is to be able to extend input_device to support all these features. The patch make changes so that input_device uses WaylandPointer and WaylandKeyboard classes internally to replace existing functionality. Any future support in these areas can be extended in those classes respectively. input_device should be responsible interface for accessing any type of input device.
Currently, display has api to query for supported InputMethod. This patch removes the api from display and adds similar api to input_device. Now, one can query the supported input method from input device.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.