Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: bump sidecar versions #977

Closed
wants to merge 1 commit into from
Closed

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jun 7, 2021

To simplify that in the future, the hack/bump-image-versions.sh gets
added which patches all locations were we define image versions.

Unnecessary variables in pkg/apis/pmemcsi/v1beta1/deployment_types.go
get removed because they were only used there and patching the file is
simpler when there is only one variable per image.

To simplify that in the future, the hack/bump-image-versions.sh gets
added which patches all locations were we define image versions.

Unnecessary variables in pkg/apis/pmemcsi/v1beta1/deployment_types.go
get removed because they were only used there and patching the file is
simpler when there is only one variable per image.
@pohly pohly requested a review from avalluri June 7, 2021 08:22
@avalluri
Copy link
Contributor

avalluri commented Jun 7, 2021

direct-testing-metrics works test panicked on 1.19:

/mnt/workspace/pmem-csi_PR-977/test/e2e/metrics/metrics.go:50
Test Panicked
/go/src/runtime/panic.go:212
Panic: runtime error: invalid memory address or nil pointer dereference
Full stack:
github.com/intel/pmem-csi/test/e2e/metrics.glob..func1.2.1()
	/mnt/workspace/pmem-csi_PR-977/test/e2e/metrics/metrics.go:81 +0x7f0
github.com/onsi/gomega.InterceptGomegaFailures(0xc0052d4ab0, 0xc0014b2660, 0x0, 0xc002627800)
	/mnt/workspace/gopath/pkg/mod/github.com/onsi/gomega@v1.10.5/gomega_dsl.go:107 +0xbb
github.com/intel/pmem-csi/test/e2e/metrics.glob..func1.2.2(0x0, 0x0)
	/mnt/workspace/pmem-csi_PR-977/test/e2e/metrics/metrics.go:107 +0x2a
reflect.Value.call(0x1af2f40, 0xc0014b2650, 0x13, 0x1de54f9, 0x4, 0xc006fbaf10, 0x0, 0x0, 0x1af2f40, 0x1, ...)
	/go/src/reflect/value.go:476 +0x8e7
reflect.Value.Call(0x1af2f40, 0xc0014b2650, 0x13, 0xc006fbaf10, 0x0, 0x0, 0xc8e04bec866, 0xc0000606d8, 0xc00005e000)
	/go/src/reflect/value.go:337 +0xb9

@pohly
Copy link
Contributor Author

pohly commented Jun 7, 2021

direct-testing-metrics works test panicked on 1.19:

I've reopened issue #972 for this.

@@ -542,7 +542,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.name
image: k8s.gcr.io/sig-storage/csi-provisioner:v2.1.1
image: k8s.gcr.io/sig-storage/csi-provisioner:v2.2.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csi-provisioner:v2.2.1 no longer supports the storage capacity alpha API, i.e. this update here cannot work.

I'll close this PR and do the sidecar update together with introducing a deployment for 1.21 where storage capacity tracking then is enabled by default.

@pohly pohly closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants