Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidental dontDeleteTmpFiles for a bus test #178

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

During development/debug, a dontDeleteTmpFiles was included on one of the tests which makes tests keep some temporary files around even when they pass. This shouldn't be there.

Related Issue(s)

N/A

Testing

Existing tests pass.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1
Copy link
Contributor Author

Might be good to add a check on #177 that tmp_test directory is empty in the CI flow.

@mkorbel1 mkorbel1 merged commit c56a7c4 into intel:main Oct 13, 2022
@mkorbel1 mkorbel1 deleted the fixbustest branch October 13, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant