Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the inline function for isValid and isFloating #216

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

priya-t12
Copy link
Contributor

Description & Motivation

Added two inline functions to Deprecate hasValidValue and isFloating in logic.dart file.
These changes are done so that users can just access value themselves to check

Related Issue(s)

Testing

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Just one adjustment.

There were some other changes in this file merged into main, so you'll have to resolve some merge conflicts by pulling those as well.

lib/src/logic.dart Outdated Show resolved Hide resolved
@mkorbel1 mkorbel1 linked an issue Dec 2, 2022 that may be closed by this pull request
lib/src/logic.dart Outdated Show resolved Hide resolved
lib/src/logic.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkorbel1 mkorbel1 merged commit a5101dd into intel:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Logic.hasValidValue and Logic.isFloating
2 participants