Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Logic.hasValidValue and Logic.isFloating #198

Closed
mkorbel1 opened this issue Nov 15, 2022 · 1 comment · Fixed by #216
Closed

Deprecate Logic.hasValidValue and Logic.isFloating #198

mkorbel1 opened this issue Nov 15, 2022 · 1 comment · Fixed by #216
Assignees
@priya-t12
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mkorbel1
Copy link
Contributor

Motivation

Other getters like Logic.valueInt and Logic.valueBigInt have been deprecated already since they just relay information from Logic.value. We should follow the same approach for other things like hasValidValue and isFloating. Users can just access value themselves to check.

Desired solution

  • Deprecate Logic.hasValidValue
  • Deprecate Logic.isFloating

Alternatives considered

No response

Additional details

No response
@mkorbel1 mkorbel1 added enhancement New feature or request good first issue Good for newcomers labels Nov 15, 2022
@priya-t12
Copy link
Contributor

I will work on this issue.

@mkorbel1 mkorbel1 linked a pull request Dec 2, 2022 that will close this issue
added the inline function for isValid and isFloating #216
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priya-t12 priya-t12

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added the inline function for isValid and isFloating priya-t12/rohd
2 participants
@mkorbel1 @priya-t12