[Issue-104] checks to prevent same conditional used multiple times #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quekyj
changed the title
mkorbel1
reviewed
Dec 16, 2022
mkorbel1
requested changes
Dec 19, 2022
quekyj
added a commit
to quekyj/rohd
that referenced
this pull request
Jan 9, 2023
quekyj
deleted the
104-checks-to-prevent-same-conditional-used-multiple-times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
If someone uses the same Conditional object multiple times in the same _Always or in different _Always blocks, it can cause unexpected behavior and simulation/synthesis mismatches.
Related Issue(s)
Fix #104
Testing
Make sure an exception is thrown when conditionals are reuse.
Backwards-compatibility
no
Documentation
no