Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added no print to the register time #301

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Added no print to the register time #301

merged 2 commits into from
Mar 7, 2023

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Mar 7, 2023

Description & Motivation

Hide the print statement of LED stream if noPrint is true.

Related Issue(s)

Fix #300

Testing

no print when run dart test.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Nope.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Nope.

@quekyj quekyj marked this pull request as ready for review March 7, 2023 02:22
mkorbel1
mkorbel1 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@mkorbel1 mkorbel1 merged commit 023fc58 into intel:main Mar 7, 2023
@quekyj quekyj deleted the 300-wrong-masked-noPrint-ovenfsm branch August 8, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print in oven_fsm.dart is not properly masked by noPrint
2 participants
@quekyj @mkorbel1