Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#334: Added enable signal to flipflop #357

Merged

Conversation

Sanchit-kumar
Copy link
Contributor

Description & Motivation

It would be nice to have an enable signal optionally provided as part of the built-in FlipFlop as per #334

Testing

Update test/flop_test.dart for the same.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Update required at official documentation. Not included by me.

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! This has been a requested feature from multiple users.

A few notes on the implementation, but the tests look great!

lib/src/modules/conditional.dart Outdated Show resolved Hide resolved
lib/src/modules/conditional.dart Show resolved Hide resolved
lib/src/modules/conditional.dart Outdated Show resolved Hide resolved
lib/src/modules/conditional.dart Show resolved Hide resolved
lib/src/modules/conditional.dart Outdated Show resolved Hide resolved
lib/src/modules/conditional.dart Outdated Show resolved Hide resolved
lib/src/modules/conditional.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more tiny things, but looks great other than that!

Also, great job on testing!

lib/src/modules/conditional.dart Show resolved Hide resolved
lib/src/modules/conditional.dart Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the contribution!

@mkorbel1 mkorbel1 linked an issue May 26, 2023 that may be closed by this pull request
@mkorbel1 mkorbel1 merged commit cf34c28 into intel:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an enable signal to FlipFlop
2 participants