[enhancement] IncrementalBasicStatistics interface #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegkkruglov
requested review from
Alexsandruss,
samir-nasibli and
KulikovNikita
as code owners
olegkkruglov
force-pushed
the
inc-lom
branch
2 times, most recently
from
c7a93cd
to
54b9cfc
Compare
samir-nasibli
previously requested changes
Jan 5, 2024
done |
|
/intelci: run |
olegkkruglov
force-pushed
the
inc-lom
branch
2 times, most recently
from
0bda1b7
to
b993e34
Compare
|
/intelci: run |
onedal/basic_statistics/tests/test_incremental_basic_statistics.py
Outdated
Show resolved
Hide resolved
onedal/basic_statistics/tests/test_incremental_basic_statistics.py
Outdated
Show resolved
Hide resolved
onedal/basic_statistics/tests/test_incremental_basic_statistics.py
Outdated
Show resolved
Hide resolved
olegkkruglov
changed the title
olegkkruglov
added
enhancement
|
/intelci: run |
1 similar comment
|
/intelci: run |
ethanglaser
reviewed
Feb 7, 2024
ethanglaser
reviewed
Feb 7, 2024
ethanglaser
reviewed
Feb 7, 2024
olegkkruglov
force-pushed
the
inc-lom
branch
from
4076c36
to
be94582
Compare
samir-nasibli
dismissed
their stale review
Request is addressed. Review is required
ethanglaser
reviewed
Apr 8, 2024
Comment on lines
+43
to
+45
| print(f"Mean:\n{result.mean}") | ||
| print(f"Max:\n{result.max}") | ||
| print(f"Sum:\n{result.sum}") |
There was a problem hiding this comment.
Can make this more specific: "Mean via automatic splitting via batch size:"
onedal/basic_statistics/tests/test_incremental_basic_statistics.py
Outdated
Show resolved
Hide resolved
| self._need_to_finalize = False | ||
|
|
||
| def _onedal_partial_fit(self, X, weights, queue): | ||
| first_pass = not hasattr(self, "n_samples_seen_") or self.n_samples_seen_ == 0 |
There was a problem hiding this comment.
are first_pass and n_samples_seen_ needed for incremental basic stats?
There was a problem hiding this comment.
first_pass is used below. and n_samples_seen_ is added for conformance. I admit there can be scenarios where user needs it.
|
/intelci: run |
|
/intelci: run |
ethanglaser
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: