-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: BasicStatistics
API change
#1644
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d54ed84
Refactored and changed interface for BasicStatistics
olegkkruglov 34be5e3
Fix rebase issues
olegkkruglov f4fb39b
Fix backend call
olegkkruglov a9a4c63
Fix _compute_raw call in KMeans
olegkkruglov d133838
Update sklearnex part
olegkkruglov feedfda
Update onedal part
olegkkruglov ba3abb2
Update tests
olegkkruglov 3804605
Adjust tolerance
olegkkruglov 4830457
Adjust tolerance
olegkkruglov a9c9d1d
Address comments
olegkkruglov 478c380
Update spmd part
olegkkruglov 2634f98
Fix lint
olegkkruglov 60ea90a
Fix rebase issues
olegkkruglov 2bb2843
Use pytest.skip, rename variables
olegkkruglov b731171
Remove redundant warning
olegkkruglov 7afed36
Update return on SPMD part
olegkkruglov 5612946
None usage aligned
olegkkruglov a4f05d2
Fix warning, add test
olegkkruglov f691a2c
Remove checks from sklearnex side
olegkkruglov 6d27ed7
Change removal year
olegkkruglov a0eebaa
Update versions in warning
olegkkruglov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for the
_get_result_options
:Inputs should be validated. For example invalid option name or empty string input.
This cases should be covered by tests.
I think make sense updated in this PR or in other smaller one either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never seen it was done anywhere in our repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't take this comment as a nitpick. Let's try to follow secure code development.
In scikit-learn-intelex mostly parameters are validated by sklearn primitives. BS has specific things to check. Worth to add some validation this string input param.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem still exists not only here but for all algos without sklearn analogues and then goes beyond this PR scope I guess. I'll create ticket for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if there are problems, I would like us to start this. This PR is a good starting point for project changes. Please add a minimum check for results_option, since API of BS is updated here.
Use with pytest.raise(ValueError) to check error raise on empty string input for results_option
Minimal validation for the input should be covered.