Benzea/adaptive improvements #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benzea
force-pushed
the
benzea/adaptive-improvements
branch
from
d4bb958
to
93c7d27
Compare
benzea
force-pushed
the
benzea/adaptive-improvements
branch
from
93c7d27
to
0e00aef
Compare
|
I have included this patchset in Fedora on 2022-02-09, and it going into F35 on 2022-02-19. So far, I have not had any reports about issues. |
|
+1, works for me, fix build issues in nixpkgs. |
added 5 commits
March 10, 2022 19:15
Clean them all up from the finalizer. Also add a helper function, and do the same in case the adaptive engine falls back to a static configuration.
The adaptive engine needs to have the sensors loaded early on in order to verify conditions. To make sure this works well, split the start function into two parts, the first being init and the second being start. For adaptive, the start function still does some verification, as the upower availability is important for the lid state (it should switch to reading the lid state directly though).
This makes more sense, and it is what libevdev expects by default.
Otherwise the switch will never change, as libevdev will just return the latest cached value.
The UPower interface for the lid state is deprecated. As such, we should be reading it directly from the input device. Making the switch is straight forward, so just do it. Closes: intel#340
benzea
force-pushed
the
benzea/adaptive-improvements
branch
from
0e00aef
to
cd9c5cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some general improvements, this includes: