[Layers] Added RotaryEmbedding forward for bc mode & Fixed rope ut #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pujiang2018
reviewed
May 11, 2024
| const int half = (dim + 1) / 2; | ||
| const int heads = std::max(qHeads, kHeads); | ||
|
|
||
| #pragma omp parallel for collapse(2) |
There was a problem hiding this comment.
currently we have imbalance tasks inside omp block, we could optimize it in next stage.
There was a problem hiding this comment.
Each row of q and k can be parallel, so it should be balanced~
There was a problem hiding this comment.
when kHeads < qHeads, it may cause imbalance issue. but anyhow, next step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.