Fix #361: Warn at compile time when using synchronous RPC

dotnet-websharper · Mar 10, 2015 · da54fe2 · da54fe2
1 parent 558dc76
commit da54fe2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/compiler/WebSharper.Compiler/Verifier.fs b/src/compiler/WebSharper.Compiler/Verifier.fs
@@ -106,10 +106,11 @@ type State(logger: Logger) =
             | None ->
                 match m.ReturnType with
                 | None -> Correct
-                | Some (Async t) | Some t ->
+                | Some (Async t) ->
                     if canEncodeToJson t
                         then Correct
                         else Incorrect "Cannot encode the return type to JSON."
+                | Some t -> Incorrect "Synchronous remote methods are strongly advised against; consider returning an Async<'T> instead."
 
     let getWebControlError (t: TypeDefinition) : Status =
         if not (canEncodeToJson t) then