Storage bug fixes #91

kingsleynweye · 2023-10-15T16:25:31Z

Description

Bug fixes in citylearn.energy_model.Storage and how electricity consumption when charging storage devices is calculated.

NIL

Fixed possibility of citylearn.energy_model.Storage.energy_init less than 0 which, is not physically possible.
Fixed case where charged energy is less than what is prescribed by controller causing electricity consumption by storage device to be overestimated.

NIL

I have tested the changes locally and they work as intended.
I have updated the documentation, if applicable.
I have added new tests, if applicable.
I have added any required dependencies to the requirements.txt file, if applicable.
I have followed the project's code style and conventions.

NIL

kingsleynweye added 3 commits October 15, 2023 09:38

set lower bound energy init to 0.0

a437957

fixed elec cons bug when charge energy > capacity

4512e81

removed unused import

6bccbe0

kingsleynweye merged commit f84ff1e into master Oct 15, 2023