Support #[macro_export(local_inner_macros)]
#3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
force-pushed
the
local-inner-macros
branch
from
c5bc383
to
d97c590
Compare
bors bot
added a commit
that referenced
this pull request
Jun 11, 2019
3749: PERF: optimize macro resolve r=Undin a=vlad20012 Initially I've tried to support [`#[macro_export(local_inner_macros)]`](https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html#macros-using-local_inner_macros) (#3750), but implementation was too slow, so I've tried to cache macro resolution better and accidentally sped it up 3 times... `local_inner_macros` is implemented in a separate RP #3750 Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jun 11, 2019
3749: PERF: optimize macro resolve r=Undin a=vlad20012 Initially I've tried to support [`#[macro_export(local_inner_macros)]`](https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html#macros-using-local_inner_macros) (#3750), but implementation was too slow, so I've tried to cache macro resolution better and accidentally sped it up 3 times... `local_inner_macros` is implemented in a separate RP #3750 Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jun 12, 2019
3749: PERF: optimize macro resolve r=undin a=vlad20012 Initially I've tried to support [`#[macro_export(local_inner_macros)]`](https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html#macros-using-local_inner_macros) (#3750), but implementation was too slow, so I've tried to cache macro resolution better and accidentally sped it up 3 times... `local_inner_macros` is implemented in a separate RP #3750 Co-authored-by: vlad20012 <beskvlad@gmail.com>
vlad20012
changed the title
#[macro_export(local_inner_macros)]
vlad20012
force-pushed
the
local-inner-macros
branch
from
d97c590
to
d79ba81
Compare
|
Is this blocked on anything? |
|
@aloucks Looks like we just forget about it :( |
|
Still forgotten? :) |
vlad20012
force-pushed
the
local-inner-macros
branch
from
d79ba81
to
83523a6
Compare
vlad20012
force-pushed
the
local-inner-macros
branch
from
83523a6
to
e0202bc
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 29, 2019
3750: Support `#[macro_export(local_inner_macros)]` r=vlad20012 a=vlad20012 Enables support for [`#[macro_export(local_inner_macros)]`](https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html#macros-using-local_inner_macros). Works only with the new macro expansion engine (see #3628). Part of #3611 Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Sep 2, 2019
4245: RUN: Add "Restart" and "Stop" buttons to Cargo build tool window r=ortem a=mchernyavsky Relates to #3926. <img width="315" alt="restart-stop" src="https://user-images.githubusercontent.com/6079006/62889650-77ffe780-bd4a-11e9-9b30-8e3ca5869f2c.png"> 4323: INT: Handle trailing comma in ChopListIntention r=mchernyavsky a=ortem 4346: Fix switch to AST when resolving nested macro with the new engine r=vlad20012 a=vlad20012 The bug was introduced in #3750 (not released yet) Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com> Co-authored-by: ortem <ortem00@gmail.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Sep 2, 2019
4323: INT: Handle trailing comma in ChopListIntention r=mchernyavsky a=ortem 4346: Fix switch to AST when resolving nested macro with the new engine r=vlad20012 a=vlad20012 The bug was introduced in #3750 (not released yet) Co-authored-by: ortem <ortem00@gmail.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables support for
#[macro_export(local_inner_macros)]. Works only with the new macro expansion engine (see #3628).Part of #3611