RUN: Support build tool window #3926

mchernyavsky · 2019-05-30T23:18:19Z

Closes #2638. Fixes #3777. Fixes #3843. Fixes #3530.

Overview:

New build toolwindow is used for build, run and test commands (except for test --doc).
Now Debug, Profile, Valgrind and Coverage runners are available only for configurations that can be built and run:
(run and test without --doc)
In CLion, "Build" (⌘+F9) is available only for configurations that can be built:
(build, run and test without --doc)
In other IDEs (e.g. IDEA, PyCharm), this button builds all projects, so is always available.
The build toolwindow should work for all OSs, cargo +1.32.0, and editions 2015/2018.
You can disable the build toolwindow by setting org.rust.cargo.build.tool.window variable to false (see Actions > Registry...).
The build toolwindow can work with -vv option (very verbose output). For example, we can understand "Fresh" compilation status:
The build toolwindow ignores --quite option. It should also ignore -q option (RUN: Ignore -q option if using new build toolwindow #4253).
You can stop the current build process using the progress indicator.
The build toolwindow runs commands with --message-format=json option. Currently JSON messages from compiler don't contain color information. See corresponding issue in Cargo issue tracker - Don't remove color information from rendered string in --message-format=json output rust-lang/cargo#6994. A partial fix - RUN: Support for ANSI colors in build tool window #4254.
2019.1 and 2019.2 have a different UI for the build toolwindow.
The build toolwindow doesn't have "Restart" and "Stop" buttons. Fix - RUN: Add "Restart" and "Stop" buttons to Cargo build tool window #4245.

Undin

You have three copy of quite big CargoBuildOutputParser class
Maybe move common code into base class to reduce code duplication?

clion/src/main/kotlin/org/rust/clion/profiler/RsProfilerRunner.kt

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildContext.kt

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildManager.kt

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildListener.kt

src/test/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildManagerTest.kt

clion/src/main/kotlin/org/rust/clion/profiler/legacy/RsProfilerRunnerLegacy.kt

lancelote · 2019-08-01T11:16:08Z

Should it report syntax errors as well? E.g. running something stupid like

fn main() {
    foo(
}

results in "Build failed" without much details so I have to run cargo in the terminal to see the error message:

cargo 1.36.0 (c4fcfb725 2019-05-15)
macOS 10.14.4

mchernyavsky · 2019-08-01T16:16:34Z

@lancelote Thanks! Should be fixed now.

src/test/kotlin/org/rustSlowTests/cargo/runconfig/buildtool/CargoBuildManagerTest.kt

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildListener.kt

src/main/kotlin/org/rust/cargo/runconfig/RsExecutableRunner.kt

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildListener.kt

mchernyavsky · 2019-08-07T14:09:26Z

bors try

bors · 2019-08-07T14:36:59Z

try

Build failed

continuous-integration/travis-ci/push

artemmukhin · 2019-08-12T16:01:22Z

bors r+

3926: RUN: Support build tool window r=ortem a=mchernyavsky Closes #2638. Fixes #3777. Fixes #3843. ![toolwindow](https://user-images.githubusercontent.com/6079006/60440179-efefd380-9c1c-11e9-9ea3-4c319552694c.gif) Overview: - TODO rust-lang/cargo#6994 Co-authored-by: mchernyavsky <mikhail.chernyavsky@jetbrains.com> Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>

bors · 2019-08-12T16:41:49Z

Build succeeded

4253: RUN: Ignore `-q` option if using new build toolwindow r=mchernyavsky a=mchernyavsky Relates to #3926. bors r+ Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>

Undin · 2019-08-13T21:03:22Z

The build toolwindow ignores --quite option. It should also ignore -q option

Why?

mchernyavsky · 2019-08-13T22:12:31Z

@Undin With --quite option Cargo still shows compiler messages (errors & warnings), but we need Cargo messages to correctly display errors in the build toolwindow.

lancelote · 2019-08-14T08:28:19Z

@mchernyavsky After disabling cargo.build.tool.window.enabled I can no longer run build run configurations. Clicking buttons has no effect, no relevant logs are recorded as well.

4257: RUN: Fix Build action when build toolwindow is disabled r=mchernyavsky a=mchernyavsky Fixes #3926 (comment). bors r+ Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>

4217: TYPE: New interactive inlay type hints support r=vlad20012 a=ortem ![type_hints](https://user-images.githubusercontent.com/4854600/62386077-7458ad80-b55f-11e9-8956-375670ffd342.gif) 4245: RUN: Add "Restart" and "Stop" buttons to Cargo build tool window r=ortem a=mchernyavsky Relates to #3926. <img width="315" alt="restart-stop" src="https://user-images.githubusercontent.com/6079006/62889650-77ffe780-bd4a-11e9-9b30-8e3ca5869f2c.png"> 4323: INT: Handle trailing comma in ChopListIntention r=mchernyavsky a=ortem Co-authored-by: ortem <ortem00@gmail.com> Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>

4245: RUN: Add "Restart" and "Stop" buttons to Cargo build tool window r=ortem a=mchernyavsky Relates to #3926. <img width="315" alt="restart-stop" src="https://user-images.githubusercontent.com/6079006/62889650-77ffe780-bd4a-11e9-9b30-8e3ca5869f2c.png"> 4323: INT: Handle trailing comma in ChopListIntention r=mchernyavsky a=ortem 4346: Fix switch to AST when resolving nested macro with the new engine r=vlad20012 a=vlad20012 The bug was introduced in #3750 (not released yet) Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com> Co-authored-by: ortem <ortem00@gmail.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>

4217: TYPE: New interactive inlay type hints support r=vlad20012 a=ortem ![type_hints](https://user-images.githubusercontent.com/4854600/62386077-7458ad80-b55f-11e9-8956-375670ffd342.gif) 4245: RUN: Add "Restart" and "Stop" buttons to Cargo build tool window r=ortem a=mchernyavsky Relates to #3926. <img width="315" alt="restart-stop" src="https://user-images.githubusercontent.com/6079006/62889650-77ffe780-bd4a-11e9-9b30-8e3ca5869f2c.png"> Co-authored-by: ortem <ortem00@gmail.com> Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>

4397: RUN: Build Action builds only selected configuration if possible r=Undin a=mchernyavsky Currently, Build Action <img width="343" alt="изображение" src="https://user-images.githubusercontent.com/6079006/64972715-70d07a00-d8b2-11e9-8e12-4faf1cb44f2a.png"> runs ``` cargo build --all --all-targets ``` even if we have selected configuration. With this PR Build Action builds only the selected configuration. E.g. for ``` cargo run --package main --bin main ``` it will run ``` cargo build --package main --bin main ``` NB: It works only if the [experimental build tool window](#3926) is enabled. NB2: CLion has its own implementation of Build Action and already knows how to build only the selected configuration. Fixes #3530, fixes #4511. Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>

4254: RUN: Support for ANSI colors in build tool window r=Undin a=mchernyavsky Relates to #3926. Fixes #4288. Fixes #4898. Note: `CARGO_TERM_PROGRESS_WHEN` and `CARGO_TERM_PROGRESS_WIDTH` variables were stabilized in the 1.48.0 release. ![image](https://user-images.githubusercontent.com/6079006/65837422-ebac8280-e2ff-11e9-8ef2-5f263f933888.png) Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com> Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>

mchernyavsky added the feature label May 30, 2019

mchernyavsky assigned artemmukhin May 30, 2019

Undin reviewed May 31, 2019

View reviewed changes

mchernyavsky changed the title ~~RUN: Support build toolwindow~~ RUN: Support build tool window Jul 1, 2019

mchernyavsky marked this pull request as ready for review July 1, 2019 13:27

mchernyavsky mentioned this pull request Jul 3, 2019

Repeat build/error messages when (Ctrl + F9) #3843

Closed

artemmukhin reviewed Jul 6, 2019

View reviewed changes

mchernyavsky added this to the v102 milestone Jul 8, 2019

artemmukhin reviewed Jul 18, 2019

View reviewed changes

src/test/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildManagerTest.kt Outdated Show resolved Hide resolved

clion/src/main/kotlin/org/rust/clion/profiler/legacy/RsProfilerRunnerLegacy.kt Show resolved Hide resolved

mchernyavsky removed this from the v102 milestone Jul 20, 2019

artemmukhin reviewed Aug 6, 2019

View reviewed changes

bors bot added a commit that referenced this pull request Aug 7, 2019

Try #3926:

2413299

mchernyavsky added this to the v104 milestone Aug 8, 2019

Undin added this to In Progress in To test Aug 9, 2019

mchernyavsky added 8 commits August 11, 2019 20:20

RUN: Build before run Cargo command

deb4224

RUN: Support build tool window

63d133d

Cleanup

b47b597

RUN: Add an internal setting to disable build tool window

4986b8b

T: Tests for build tool window

5dc46a4

RUN: Disable build tool window for cargo < 1.32.0

3076b02

RUN: Don't run build and test --no-run commands

f6dd639

RUN: Disable some runners for build and test --no-run commands

7564b1b

bors bot merged commit 7564b1b into intellij-rust:master Aug 12, 2019

To test automation moved this from In Progress to Test Aug 12, 2019

mchernyavsky deleted the build-run branch August 12, 2019 16:56

mchernyavsky mentioned this pull request Aug 13, 2019

RUN: Ignore -q option if using new build toolwindow #4253

Merged

bors bot added a commit that referenced this pull request Aug 13, 2019

Merge #4253

d2f7564

4253: RUN: Ignore `-q` option if using new build toolwindow r=mchernyavsky a=mchernyavsky Relates to #3926. bors r+ Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>

bors bot added a commit that referenced this pull request Aug 13, 2019

Merge #4253

0c9667c

4253: RUN: Ignore `-q` option if using new build toolwindow r=mchernyavsky a=mchernyavsky Relates to #3926. bors r+ Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>

mchernyavsky mentioned this pull request Aug 13, 2019

RUN: Support for ANSI colors in build tool window #4254

Merged

This was referenced Aug 14, 2019

RUN: Add "Restart" and "Stop" buttons to Cargo build tool window #4245

Merged

RUN: Fix Build action when build toolwindow is disabled #4257

Merged

bors bot added a commit that referenced this pull request Aug 14, 2019

Merge #4257

1f23532

4257: RUN: Fix Build action when build toolwindow is disabled r=mchernyavsky a=mchernyavsky Fixes #3926 (comment). bors r+ Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>

bors bot added a commit that referenced this pull request Aug 14, 2019

Merge #4257

d69c599

4257: RUN: Fix Build action when build toolwindow is disabled r=mchernyavsky a=mchernyavsky Fixes #3926 (comment). bors r+ Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>

Undin added the to be documented Pull requests that should be documented label Aug 14, 2019

lancelote moved this from Test to Done in To test Aug 26, 2019

This was referenced Sep 13, 2019

Disable the default --all flag when building. #4386

Closed

RUN: Build Action builds only selected configuration if possible #4397

Merged

This was referenced Nov 8, 2019

Rust Plugin's code converage is not work for my project. #4605

Open

Add an option/variable to print progress bar in a machine-readable format rust-lang/cargo#7587

Closed

Problems tool window missing #4632

Closed

mchernyavsky mentioned this pull request Mar 10, 2020

Not possible to enable features when building project #5078

Closed

mchernyavsky mentioned this pull request Apr 15, 2020

IDEA Intellij & Rust plugin do not work after latest Intellij & Rust plugin updates #5237

Closed

mchernyavsky mentioned this pull request Sep 28, 2021

Have any plan to support remote build/run? #4651

Closed

MarinaKalashina removed the to be documented Pull requests that should be documented label Oct 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RUN: Support build tool window #3926

RUN: Support build tool window #3926

mchernyavsky commented May 30, 2019 •

edited

Undin left a comment

lancelote commented Aug 1, 2019 •

edited

mchernyavsky commented Aug 1, 2019

mchernyavsky commented Aug 7, 2019

bors bot commented Aug 7, 2019

artemmukhin commented Aug 12, 2019

bors bot commented Aug 12, 2019

Undin commented Aug 13, 2019

mchernyavsky commented Aug 13, 2019

lancelote commented Aug 14, 2019

RUN: Support build tool window #3926

RUN: Support build tool window #3926

Conversation

mchernyavsky commented May 30, 2019 • edited

Undin left a comment

Choose a reason for hiding this comment

lancelote commented Aug 1, 2019 • edited

mchernyavsky commented Aug 1, 2019

mchernyavsky commented Aug 7, 2019

bors bot commented Aug 7, 2019

try

Build failed

artemmukhin commented Aug 12, 2019

bors bot commented Aug 12, 2019

Build succeeded

Undin commented Aug 13, 2019

mchernyavsky commented Aug 13, 2019

lancelote commented Aug 14, 2019

mchernyavsky commented May 30, 2019 •

edited

lancelote commented Aug 1, 2019 •

edited