DBG: Load pretty-printers and rustc sources via RsDebugProcessConfigurator #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
reviewed
Jul 30, 2019
There was a problem hiding this comment.
Now, we have a lot of unnecessary code duplication between debugger/192 and debugger/191 source sets.
To avoid it I suggest:
- make 191 and 192 version of
RsLocalDebugProcess - extract all difference between 191 and 192
RsDebugRunnertoRsLocalDebugProcess#setupDebugSessionmethod (don't insist on method name). It seems for 192 this method will do nothing - move
RsDebugRunnerto common source set - move
Loaderto common source set and use it in 191RsLocalDebugProcessand 192RsDebugProcessConfigurator
Also, it should reduce code dublication and reduce conflicts with #3926
debugger/src/192/main/kotlin/org/rust/debugger/runconfig/RsDebugProcessConfigurator.kt
Outdated
Show resolved
Hide resolved
debugger/src/192/main/kotlin/org/rust/debugger/runconfig/RsDebugProcessConfigurator.kt
Outdated
Show resolved
Hide resolved
debugger/src/192/main/kotlin/org/rust/debugger/runconfig/RsDebugProcessConfigurator.kt
Outdated
Show resolved
Hide resolved
debugger/src/192/main/kotlin/org/rust/debugger/runconfig/RsDebugProcessConfigurator.kt
Outdated
Show resolved
Hide resolved
debugger/src/192/main/kotlin/org/rust/debugger/runconfig/RsDebugProcessConfigurator.kt
Outdated
Show resolved
Hide resolved
Undin
reviewed
Jul 30, 2019
artemmukhin
force-pushed
the
load-pretty-printers-clion
branch
from
f9bc209
to
8fd3d49
Compare
artemmukhin
changed the title
artemmukhin
changed the title
Undin
reviewed
Jul 30, 2019
debugger/src/192/main/kotlin/org/rust/debugger/runconfig/RsDebugProcessConfigurator.kt
Outdated
Show resolved
Hide resolved
debugger/src/main/kotlin/org/rust/debugger/runconfig/RsExtraDebugDataLoader.kt
Outdated
Show resolved
Hide resolved
debugger/src/main/kotlin/org/rust/debugger/runconfig/RsExtraDebugDataLoader.kt
Outdated
Show resolved
Hide resolved
artemmukhin
force-pushed
the
load-pretty-printers-clion
branch
2 times, most recently
from
630f00c
to
7073e45
Compare
Undin
reviewed
Aug 1, 2019
debugger/src/191/main/kotlin/org/rust/debugger/runconfig/RsLocalDebugProcess.kt
Outdated
Show resolved
Hide resolved
artemmukhin
force-pushed
the
load-pretty-printers-clion
branch
from
7073e45
to
5048f5b
Compare
|
@Undin Oh, really. Now in case of cross-language projects, Rust LLDB pretty-printers are enabled only for specific std types, but disabled for arbitrary struct/enum. On the other hand, GDB should work well in this case because it tries to apply all pretty-printers consequentially and doesn't rely on regexes. |
Undin
reviewed
Aug 5, 2019
debugger/src/main/kotlin/org/rust/debugger/runconfig/RsDebugProcessConfigurationHelper.kt
Show resolved
Hide resolved
artemmukhin
force-pushed
the
load-pretty-printers-clion
branch
from
5048f5b
to
fb2ada2
Compare
bors bot
added a commit
that referenced
this pull request
Aug 6, 2019
4197: DBG: Load pretty-printers and rustc sources via RsDebugProcessConfigurator r=Undin a=ortem Now Rust pretty-printers and rustc sources will be loaded even when C/C++ project was launched. So debugging Rust code inside a cross-language project becomes as comfortable as debugging pure-Rust projects. Co-authored-by: ortem <ortem00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Rust pretty-printers and rustc sources will be loaded even when C/C++ project was launched. So debugging Rust code inside a cross-language project becomes as comfortable as debugging pure-Rust projects.