Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUN: Support for ANSI colors in build tool window #4254

Merged
merged 3 commits into from Dec 17, 2020
Merged

RUN: Support for ANSI colors in build tool window #4254

merged 3 commits into from Dec 17, 2020

Conversation

mchernyavsky
Copy link
Member

@mchernyavsky mchernyavsky commented Aug 13, 2019 •
edited

Relates to #3926.

Fixes #4288.
Fixes #4898.

Note: CARGO_TERM_PROGRESS_WHEN and CARGO_TERM_PROGRESS_WIDTH variables were stabilized in the 1.48.0 release.

image

@mchernyavsky mchernyavsky added the fix Pull requests that fix some bug(s) label Aug 13, 2019
@mchernyavsky mchernyavsky added this to In Progress in To test via automation Aug 13, 2019
@mchernyavsky mchernyavsky mentioned this pull request Aug 13, 2019
Merged
@mchernyavsky mchernyavsky added this to the v105 milestone Aug 17, 2019
@mchernyavsky mchernyavsky changed the title RUN: Partial support for ANSI colors in build toolwindow WIP: Partial support for ANSI colors in build toolwindow Aug 19, 2019
@mchernyavsky mchernyavsky mentioned this pull request Aug 22, 2019
Closed
@mchernyavsky mchernyavsky changed the title WIP: Partial support for ANSI colors in build toolwindow RUN: Partial support for ANSI colors in build toolwindow Aug 26, 2019
@mchernyavsky mchernyavsky modified the milestones: v105, v106 Sep 2, 2019
@mchernyavsky mchernyavsky modified the milestones: v106, v107 Sep 17, 2019
@mchernyavsky
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 25, 2019
@bors
Try #4254:
03edae3
@bors
Copy link
Contributor

bors bot commented Sep 25, 2019

try

Build failed

@mchernyavsky
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 28, 2019
@bors
Try #4254:
c9b73f9
@bors
Copy link
Contributor

bors bot commented Sep 28, 2019

try

Build failed

@mchernyavsky mchernyavsky changed the title RUN: Partial support for ANSI colors in build toolwindow RUN: Support for ANSI colors in build tool window Sep 29, 2019
@mchernyavsky
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 29, 2019
@bors
Try #4254:
76954ac
@bors
Copy link
Contributor

bors bot commented Sep 29, 2019

try

Build failed

@mchernyavsky mchernyavsky force-pushed the fix-build-toolwindow-colors branch 2 times, most recently from 34bf78d to bad5c35 Compare September 29, 2019 21:38
@mchernyavsky mchernyavsky mentioned this pull request Dec 1, 2020
Closed
@Undin Undin self-assigned this Dec 2, 2020
Undin
Undin approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@Undin Undin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks ok

Some notes/questions:

  • looks like some tests fail with Rust 1.32
  • are we going to enable test for build functionality on CI?

src/main/kotlin/org/rust/openapiext/Json.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/openapiext/Json.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/openapiext/Json.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/buildtool/RsBuildEventsConverter.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildAdapter.kt Outdated Show resolved Hide resolved
artemmukhin
artemmukhin reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@artemmukhin artemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I haven't run this for now, only read the code. I'm going to test it on my machine tomorrow

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildAdapter.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildContext.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/buildtool/RsBuildEventsConverter.kt Show resolved Hide resolved
@artemmukhin
Copy link
Member

artemmukhin commented Dec 3, 2020 •
edited

I tried this on macOS and Windows, and it generally works and looks nice, except for one thing.

On Windows, I faced with invisible white text with the white color scheme (2020.3)
Screenshot 2020-12-03 at 20 01 34

On macOS, however, it works just fine
Screenshot 2020-12-03 at 20 03 25

@artemmukhin
Copy link
Member

Also, discussed in person that the description of our Build tool window registry option should mention the new Rust 1.48 requirement

@mchernyavsky
Copy link
Member Author

mchernyavsky commented Dec 10, 2020 •
edited

are we going to enable test for build functionality on CI?

@Undin No.

On Windows, I faced with invisible white text with the white color scheme (2020.3)

@ortem This issue doesn't relate to this PR (it's about some changes in 203). I will fix it in another PR. Fixed.

@Undin
Copy link
Member

Undin commented Dec 11, 2020

are we going to enable test for build functionality on CI?

@Undin No.

Why?

@mchernyavsky
Copy link
Member Author

@Undin Because they are flashing.

@mchernyavsky
Copy link
Member Author

@Undin Fixed.

artemmukhin
artemmukhin approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@artemmukhin artemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with invisible white text seems to be solved.

Except for the potential problems with shared mutable state (which can be fixed in a separate PR later), this generally LGTM.

@mchernyavsky
Copy link
Member Author

@Undin @ortem Fixed

Undin
Undin approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 17, 2020

Build succeeded:

@bors bors bot merged commit 118d9d9 into master Dec 17, 2020
To test automation moved this from In Progress to Test Dec 17, 2020
@bors bors bot deleted the fix-build-toolwindow-colors branch December 17, 2020 20:06
@github-actions github-actions bot added this to the v138 milestone Dec 17, 2020
@Undin
Copy link
Member

Undin commented Dec 17, 2020

@mchernyavsky I suppose it fixes #4934, right?

@mchernyavsky mchernyavsky mentioned this pull request Dec 18, 2020
Closed
@lancelote lancelote moved this from Test to Done in To test Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin approved these changes

@artemmukhin artemmukhin artemmukhin approved these changes

Assignees

@Undin Undin

@artemmukhin artemmukhin

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v138
Development

Successfully merging this pull request may close these issues.

Improve rustc/cargo message support/parsing. Build tool window does not display anything
4 participants
@mchernyavsky @Kobzol @artemmukhin @Undin