Improve CratesLocalIndexService internals #6898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avrong
added
the
internal
Undin
reviewed
Feb 28, 2021
toml/src/main/kotlin/org/rust/toml/crates/local/CratesLocalIndexServiceImpl.kt
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/crates/local/CratesLocalIndexServiceImpl.kt
Outdated
Show resolved
Hide resolved
Undin
removed
the
internal
avrong
force-pushed
the
avrong/crates-local-index-fixes
branch
from
b4e02d2
to
57e6529
Compare
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Apr 3, 2021
7031: Fix crates local index state updates r=Undin a=avrong Bug introduced by changes in #6898. Using `val` for a state field doesn't make it possible to serialize and save it, so it was being ignored. changelog: Fix unnecessary reload of crates local index after IDE restart. Co-authored-by: Aleksei Trifonov <avrong@avrong.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comments in #6390.
CratesLocalIndexState's field immutableisReadyby a doc comment, not sure what's the better name for it can be