Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crates local index state updates #7031

Merged
merged 1 commit into from Apr 3, 2021

Conversation

avrong
Copy link
Member

@avrong avrong commented Mar 28, 2021

Bug introduced by changes in #6898. Using val for a state field doesn't make it possible to serialize and save it, so it was being ignored.

changelog: Fix unnecessary reload of crates local index after IDE restart.

@avrong avrong added the fix Pull requests that fix some bug(s) label Mar 28, 2021
@avrong avrong requested a review from Undin March 28, 2021 11:32
@avrong avrong force-pushed the avrong/crates-local-index-state-fix branch from 691fed9 to d22e2b0 Compare March 29, 2021 12:31
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks ok
Consider using modern API: SimplePersistentStateComponent and BaseState. I suppose it may slightly simplify implementation by dropping some boilerplate code

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 3, 2021

Build succeeded:

@bors bors bot merged commit 8fd4604 into master Apr 3, 2021
@github-actions github-actions bot added this to the v145 milestone Apr 3, 2021
@Undin Undin deleted the avrong/crates-local-index-state-fix branch April 5, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants