Do not evaluate unknown cfg to false in stdlib crates #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `org.rust.cargo.fetch.actual.stdlib.metadata` feature is enabled, we know that stdlib crates have build scripts. Previously, we tried to evaluate unknown cfg options that led to unresolved references in some cases. For example, `panic!` macro has two versions with `cfg(bootstrap)` and `cfg(not(bootstrap))` on 1.51.0 and in combination with the current name resolution engine, it cannot be resolved. Now the plugin doesn't evaluate unknown options (at least temporarily) in stdlib crates.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 5, 2021
7053: Do not evaluate unknown cfg to false in stdlib crates r=vlad20012 a=Undin When `org.rust.cargo.fetch.actual.stdlib.metadata` feature is enabled, we know that stdlib crates have build scripts. Previously, we tried to evaluate unknown cfg options that led to unresolved references in some cases. For example, `panic!` macro has two versions with `cfg(bootstrap)` and `cfg(not(bootstrap))` on 1.51.0 and in combination with the current name resolution engine, it cannot be resolved. Now the plugin doesn't evaluate unknown options (at least temporarily) in stdlib crates. changelog: Fix name resolution of items in standard library with `cfg` attribute in some cases Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
org.rust.cargo.fetch.actual.stdlib.metadatafeature is enabled, we know that stdlib crates have build scripts.Previously, we tried to evaluate unknown cfg options that led to unresolved references in some cases.
For example,
panic!macro has two versions withcfg(bootstrap)andcfg(not(bootstrap))on 1.51.0 and in combination with the current name resolution engine, it cannot be resolved.Now the plugin doesn't evaluate unknown options (at least temporarily) in stdlib crates.
changelog: Fix name resolution of items in standard library with
cfgattribute in some cases