Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not evaluate unknown cfg to false in stdlib crates #7053

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Do not evaluate unknown cfg to false in stdlib crates #7053

merged 1 commit into from
Apr 5, 2021

Commits on Apr 5, 2021

  1. Do not evaluate unknown cfg to false in stdlib crates 

    When `org.rust.cargo.fetch.actual.stdlib.metadata` feature is enabled, we know that stdlib crates have build scripts.

Previously, we tried to evaluate unknown cfg options that led to unresolved references in some cases.
For example, `panic!` macro has two versions with `cfg(bootstrap)` and `cfg(not(bootstrap))` on 1.51.0 and in combination with the current name resolution engine, it cannot be resolved.

Now the plugin doesn't evaluate unknown options (at least temporarily) in stdlib crates.
    @Undin
    Undin committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    2391aa1 View commit details
    Browse the repository at this point in the history