Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: use aliases in Extract function refactoring #7627

Merged
merged 1 commit into from
Aug 6, 2021
Merged

REF: use aliases in Extract function refactoring #7627

merged 1 commit into from
Aug 6, 2021

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 5, 2021

This PR modifies the Extract function refactoring so that it respects aliases. Same as with skipUnchangedDefaultTypeArguments, I think that useAliasNames should default to true.

changelog: Respect type aliases in Extract function refactoring.

@Kobzol Kobzol added the fix Pull requests that fix some bug(s) label Aug 5, 2021
@Kobzol Kobzol requested a review from vlad20012 August 5, 2021 11:48
vlad20012
vlad20012 approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Aug 6, 2021

Build succeeded:

@bors bors bot merged commit 18a6d41 into intellij-rust:master Aug 6, 2021
@github-actions github-actions bot added this to the v153 milestone Aug 6, 2021
@Kobzol Kobzol deleted the ref-extract-function-use-alises branch August 6, 2021 21:36
@mili-l mili-l self-assigned this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

Assignees

@mili-l mili-l

Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Milestone
v153
Development

Successfully merging this pull request may close these issues.
3 participants
@Kobzol @vlad20012 @mili-l