RUN: show build error balloon over proper tool window #7792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, build manager showed build error balloon over `Messages` tool window tab for some reason. But the plugin doesn't interact with this tool window at all and prints all build output to `Build` tool window. Moreover, in most cases `Messages` tool window doesn't have any active tab and a user can't even open it. It's rather confusing After these changes the plugin will show build error balloon over `Build` tool window tab to be consistent with build output and not confuse users
Undin
commented
Sep 4, 2021
| @@ -270,10 +268,9 @@ object CargoBuildManager { | |||
| notification.notify(project) | |||
|
|
|||
| if (messageType === MessageType.ERROR) { | |||
| MessageView.SERVICE.getInstance(project) // register ToolWindowId.MESSAGES_WINDOW | |||
There was a problem hiding this comment.
Not sure that we don't need call BuildContentManager.getInstance(project).getOrCreateToolWindow() here instead.
@mchernyavsky why did we call it here before?
There was a problem hiding this comment.
I'm not sure. It is copypasted from CidrBuild.showBuildNotification :)
|
For QA: I've changed some code with tool window initialization, so it would be cool to check not only balloon location but also that |
|
bors r=mchernyavsky |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, build manager showed build error balloon over
Messagestool window tab for some reason.But the plugin doesn't interact with this tool window at all and prints all build output to
Buildtool window.Moreover, in most cases
Messagestool window doesn't have any active tab and a user can't even open it. It's rather confusingAfter these changes, the plugin will show build error balloon over
Buildtool window tab to be consistent with build output and not confuse userschangelog: Show build error balloon over
Buildtool window instead ofMessagesone