Fix untrusted notifications in Cargo projects #8167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coming versions of IntelliJ IDE (more specifically 2021.2.4 and 2021.3.1) will bring changes in untrusted editor notification. Now, if a project is opened in safe mode, IDE will show the corresponding editor notification in all files itself. That leads to double editor notification since the plugin shows its own notification as well. These changes prepare the plugin for platform changes, and now the editor notification about untrusted project will be shown only once. Also, they fix `trust project` action in the notification that doesn't work with stable plugin builds because of changes in the platform (`TrustChangeNotifier` was renamed to `TrustStateListener`)
Undin
added
the
internal
vlad20012
approved these changes
Nov 26, 2021
bors bot
added a commit
that referenced
this pull request
Nov 28, 2021
8167: Fix untrusted notifications in Cargo projects r=mchernyavsky a=Undin Coming versions of IntelliJ IDE (more specifically 2021.2.4 and 2021.3.1) will bring changes in untrusted editor notification. Now, if a project is opened in safe mode, IDE will show the corresponding editor notification in all files itself. That leads to double editor notification since the plugin shows its own notification as well. <img width="782" alt="Screen Shot 2021-11-24 at 16 51 58" src="https://user-images.githubusercontent.com/2539310/143281497-36fbe0c7-62cc-47df-a3f5-9090289b02d7.png"> These changes prepare the plugin for platform changes, and now the editor notification about untrusted project will be shown only once. Also, they fix `trust project` action in the notification that doesn't work with stable plugin builds because of changes in the platform (`TrustChangeNotifier` was renamed to `TrustStateListener`) changelog: Prepare plugin for upcoming changes in untrusted editor notification Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 28, 2021
8167: Fix untrusted notifications in Cargo projects r=mchernyavsky a=Undin Coming versions of IntelliJ IDE (more specifically 2021.2.4 and 2021.3.1) will bring changes in untrusted editor notification. Now, if a project is opened in safe mode, IDE will show the corresponding editor notification in all files itself. That leads to double editor notification since the plugin shows its own notification as well. <img width="782" alt="Screen Shot 2021-11-24 at 16 51 58" src="https://user-images.githubusercontent.com/2539310/143281497-36fbe0c7-62cc-47df-a3f5-9090289b02d7.png"> These changes prepare the plugin for platform changes, and now the editor notification about untrusted project will be shown only once. Also, they fix `trust project` action in the notification that doesn't work with stable plugin builds because of changes in the platform (`TrustChangeNotifier` was renamed to `TrustStateListener`) changelog: Prepare plugin for upcoming changes in untrusted editor notification Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 28, 2021
8167: Fix untrusted notifications in Cargo projects r=mchernyavsky a=Undin Coming versions of IntelliJ IDE (more specifically 2021.2.4 and 2021.3.1) will bring changes in untrusted editor notification. Now, if a project is opened in safe mode, IDE will show the corresponding editor notification in all files itself. That leads to double editor notification since the plugin shows its own notification as well. <img width="782" alt="Screen Shot 2021-11-24 at 16 51 58" src="https://user-images.githubusercontent.com/2539310/143281497-36fbe0c7-62cc-47df-a3f5-9090289b02d7.png"> These changes prepare the plugin for platform changes, and now the editor notification about untrusted project will be shown only once. Also, they fix `trust project` action in the notification that doesn't work with stable plugin builds because of changes in the platform (`TrustChangeNotifier` was renamed to `TrustStateListener`) changelog: Prepare plugin for upcoming changes in untrusted editor notification Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
|
Build failed: |
|
bors r=mchernyavsky |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Dec 24, 2021
8018: UI: Add a widget and some notifications for external linter r=vlad20012 a=mchernyavsky <img width="351" alt="Screenshot 2021-11-12 at 02 18 21" src="https://user-images.githubusercontent.com/6079006/141382780-e61f516c-f0f4-4ea0-ab45-2dec18c8fb86.png"> <img width="385" alt="Screenshot 2021-11-12 at 04 02 08" src="https://user-images.githubusercontent.com/6079006/141390897-ccc37321-ab2b-4b92-b37d-a0e6c43260b2.png"> <img width="357" alt="Screenshot 2021-11-12 at 02 20 45" src="https://user-images.githubusercontent.com/6079006/141382787-eeb1460e-9e41-494e-8099-01a73ca5e81e.png"> <img width="357" alt="Screenshot 2021-11-12 at 02 20 26" src="https://user-images.githubusercontent.com/6079006/141382784-a40a0523-5d9d-4642-afd5-01f88ef34957.png"> Also, see `org.rust.external.linter.max.duration` registry option. changelog: Add a widget for the external linter and notify a user about the linter is turned on/off or if the linter significantly affects performance on the project 8269: INT: correctly parenthesize block-like expressions in Inline Value refactoring r=vlad20012 a=Kobzol Turns out that I have missed a few cases that require parentheses in `RsInlineValueProcessor`. Fixes: #8267 changelog: Correctly parenthesize block-like expressions (e.g. `match`) in Inline Value refactoring. 8332: Update ra_ap_proc_macro_srv to 0.0.87 r=vlad20012 a=vlad20012 ... and enable Dependabot. Previous - #8278 8334: Don't perform cargo refresh when another IDE project become trusted r=vlad20012 a=vlad20012 The bug was introduced in #8167. When some IDEA project is marked as trusted, `cargo refresh` action is performed in all other opened projects. This also lead to flaky tests https://user-images.githubusercontent.com/3221931/147363985-9ea94a7a-6449-4f96-bdeb-4a17d1f84124.mp4 Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com> Co-authored-by: Jakub Beránek <berykubik@gmail.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming versions of IntelliJ IDE (more specifically 2021.2.4 and 2021.3.1) will bring changes in untrusted editor notification.
Now, if a project is opened in safe mode, IDE will show the corresponding editor notification in all files itself. That leads to double editor notification since the plugin shows its own notification as well.
These changes prepare the plugin for platform changes, and now the editor notification about untrusted project will be shown only once. Also, they fix
trust projectaction in the notification that doesn't work with stable plugin builds because of changes in the platform (TrustChangeNotifierwas renamed toTrustStateListener)changelog: Prepare plugin for upcoming changes in untrusted editor notification