Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't perform cargo refresh when another IDE project become trusted #8334

Merged
merged 1 commit into from Dec 24, 2021

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented Dec 24, 2021

The bug was introduced in #8167. When some IDEA project is marked as trusted, cargo refresh action is performed in all other opened projects. This also lead to flaky tests

Peek.2021-12-24.19-11.mp4

@vlad20012 vlad20012 added the fix Pull requests that fix some bug(s) label Dec 24, 2021
@vlad20012 vlad20012 force-pushed the dont-cargo-refresh-when-other-project-is-trusted branch from 3cf753f to 085cf3a Compare December 24, 2021 15:45
@vlad20012 vlad20012 added this to In Progress in To test via automation Dec 24, 2021
@vlad20012 vlad20012 self-assigned this Dec 24, 2021
@vlad20012
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 24, 2021

Build succeeded:

@bors bors bot merged commit 698eb3a into master Dec 24, 2021
To test automation moved this from In Progress to Test Dec 24, 2021
@bors bors bot deleted the dont-cargo-refresh-when-other-project-is-trusted branch December 24, 2021 21:35
@github-actions github-actions bot added this to the v163 milestone Dec 24, 2021
@neonaot neonaot self-assigned this Dec 27, 2021
@neonaot neonaot moved this from Test to Done in To test Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants