Refactor completion variants sorting: use weighers #8514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
added
the
internal
This was referenced Feb 5, 2022
vlad20012
changed the title
artemmukhin
approved these changes
Feb 7, 2022
src/main/kotlin/org/rust/lang/core/completion/RsCompletionContributor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/completion/RsCompletionContributor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/completion/RsLookupElement.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/completion/sort/RsCompletionSorting.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/completion/sort/RsCompletionSorting.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/completion/sort/RsCompletionSorting.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/completion/sort/RsCompletionWeigher.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/completion/sort/RsCompletionSorting.kt
Outdated
Show resolved
Hide resolved
vlad20012
force-pushed
the
completion-sorting-weighers
branch
4 times, most recently
from
1927a0d
to
b43cfd8
Compare
vlad20012
force-pushed
the
completion-sorting-weighers
branch
from
b43cfd8
to
b2dd3fe
Compare
|
bors r=ortem |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes nothing for the end-user (i.e. the new sorting should work exactly like the old one).
For us, this tidies up completion variants sorting. Please read docs for
RS_COMPLETION_WEIGHERS