Migrate plugin to new plugin model #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
added
the
internal
Undin
force-pushed
the
undin/new-plugin-model
branch
2 times, most recently
from
9b428a8
to
b6c0eb4
Compare
Undin
force-pushed
the
undin/new-plugin-model
branch
2 times, most recently
from
3e548a5
to
5d43aa7
Compare
Undin
force-pushed
the
undin/new-plugin-model
branch
from
5d43aa7
to
d9295d2
Compare
Plugin model v2 requires all plugin manifest are located in single jar file
Otherwise, the platform throws exception because of usage of package of another module (`org.rust.debug`)
The plugin has to declare additional dependency to `intellij.profiler.clion` CLion module to use profiler classes because of using new plugin model. Otherwise, the platform throws exception during loading classes from `intellij.profiler.clion`. These changes extract all profiler code into separate Gradle module to provide separate plugin module manifest with necessary dependency. Also, it allows us not to make unnecessary connection between common CLion code and profiler integration
The hack was introduced in #8666. Now the platform properly checks dependencies of modules (optional dependencies in plugin model v1) so we can drop it
Undin
force-pushed
the
undin/new-plugin-model
branch
from
d9295d2
to
48b7afe
Compare
vlad20012
approved these changes
Apr 25, 2022
|
bors r=vlad20012 |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2022
9295: GRD: fix searchable options building r=Undin a=Undin Building of searchable options was broken by migration to new plugin model (#8709). As a result, `Find Action` dialog and settings search cannot find options provided by the plugin. These changes fix Gradle `buildSearchableOptions` task | Before | After | | - | - | | <img width="716" alt="Screenshot 2022-09-03 at 17 17 07" src="https://user-images.githubusercontent.com/2539310/188277053-c0333e4c-cb54-4dcb-adf8-d0cd796e2bd0.png"> | <img width="716" alt="Screenshot 2022-09-03 at 17 07 17" src="https://user-images.githubusercontent.com/2539310/188277059-5ece0e97-4905-4dc6-ae67-c3324f1e11fe.png"> | | <img width="1012" alt="Screenshot 2022-09-03 at 17 17 17" src="https://user-images.githubusercontent.com/2539310/188277069-7002bcd7-33c0-4873-9e89-5869a04fa9d4.png"> | <img width="1094" alt="Screenshot 2022-09-03 at 17 07 43" src="https://user-images.githubusercontent.com/2539310/188277081-3a591d24-9eff-4f2a-90c2-941477873178.png"> | changelog: Fix search of the plugin settings in `Find Action` dialog and `Settings` window which was broken in [#8709](#8709) Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short description of the new plugin model (AKA plugin model v2) can be found here
The main idea of the new plugin model is to convert a big plugin with "optional dependencies" into a graph of small plugins with explicit dependencies between them (of course, in UI there is still only one plugin). It should simplify making plugin dynamic unloadable (in theory).
In practice, these changes allow us to rely on all dependencies of modules (where module is "optional dependency" in plugin model v1) and avoid issues like #8622
From a user point of view, these changes allow users to install Rust and Toml at the same time dynamically, i.e. without IDE restart. Previously, it was possible if Toml plugin was already installed
Depends on #8708
changelog: internal: Migrate plugin to new plugin model. feature: Allow installing Rust plugin together with Toml plugin without IDE restart. Note, Rust plugin update still requires IDE restart