-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TY: improve type inference around call expressions #8790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
force-pushed
the
ty-call-deref
branch
from
April 25, 2022 20:10
2206e49
to
5e3dfd6
Compare
vlad20012
force-pushed
the
ty-call-deref
branch
3 times, most recently
from
April 26, 2022 13:36
7db2b13
to
9df0aee
Compare
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 26, 2022
8790: TY: improve type inference around call expressions r=vlad20012 a=vlad20012 Not the plugin should support these cases: ```rust fn foo(f: &&fn() -> i32) { let a = f(); a; } //^ i32 ``` and ```rust use std::rc::Rc; fn foo(f: Rc<fn() -> i32>) { let a = f(); a; } //^ i32 ``` and ```rust struct S(); impl S { fn new() { let a = Self(); a; } //^ S } ``` Also, I moved E0618 implementation into the type inference engine, so it should work more precisely. Fixes #6682 Fixes #8311 Co-authored-by: vlad20012 <beskvlad@gmail.com>
Canceled. |
vlad20012
force-pushed
the
ty-call-deref
branch
from
April 26, 2022 15:14
9df0aee
to
3c49581
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the plugin should support these cases:
and
and
Also, I moved E0618 implementation into the type inference engine, so it should work more precisely.
Fixes #6682
Fixes #8311