Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Fix redundant macro completion in mod item name #9152

Merged
merged 1 commit into from Aug 7, 2022
Merged

COMP: Fix redundant macro completion in mod item name #9152

merged 1 commit into from Aug 7, 2022

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Aug 2, 2022

Fixes #7780

changelog: Fix redundant macro completion in mod item name

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Aug 2, 2022
@dima74 dima74 added this to In Progress in To test via automation Aug 2, 2022
vlad20012
vlad20012 approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 7, 2022

Build succeeded:

  • check

@bors bors bot merged commit 65fe1e5 into master Aug 7, 2022
To test automation moved this from In Progress to Test Aug 7, 2022
@bors bors bot deleted the diralik/fix-mod-name-completion-macro branch August 7, 2022 14:36
@github-actions github-actions bot added this to the v176 milestone Aug 7, 2022
@mili-l mili-l self-assigned this Aug 9, 2022
@mili-l mili-l moved this from Test to Done in To test Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

Assignees

@mili-l mili-l

@vlad20012 vlad20012

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v176
Development

Successfully merging this pull request may close these issues.

Macro completion shouldn't happen in module declarations
3 participants
@dima74 @vlad20012 @mili-l