Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark unused public reexports in binary crates #9271

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Aug 31, 2022

Other crates can't depend on binary crates, so pub reexports in binary crates are effectively pub(crate) and can be marked unused if so.

changelog: Support "Unused imports" inspection for public reexports in binary crates

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Aug 31, 2022
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dima74 dima74 force-pushed the diralik/public-unused-import-bin-crate branch from daab8e9 to 5ed5d12 Compare September 5, 2022 17:17
@dima74
Copy link
Member Author

dima74 commented Sep 5, 2022

bors r=vlad20012

@bors bors bot merged commit 8c7d570 into master Sep 5, 2022
@bors
Copy link
Contributor

bors bot commented Sep 5, 2022

Build succeeded:

@bors bors bot deleted the diralik/public-unused-import-bin-crate branch September 5, 2022 23:57
@github-actions github-actions bot added this to the v179 milestone Sep 5, 2022
@neonaot neonaot self-assigned this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants