Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Substitute Self in "Inline function" refactoring #9525

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Oct 13, 2022

Related: #9429
Meta: #5511

changelog: Substitute Self in Inline function refactoring

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Oct 13, 2022
@dima74 dima74 force-pushed the diralik/inline-function-Self branch from af952ff to 3f4041a Compare October 13, 2022 23:11
@dima74 dima74 changed the title REF: Substitute Self in "Inline function" refactoring REF: Substitute Self in "Inline function" refactoring Oct 13, 2022
Copy link
Member

@artemmukhin artemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's also add a corresponding item to the improvements list in #5511

@dima74
Copy link
Member Author

dima74 commented Nov 1, 2022

bors r=ortem

@bors
Copy link
Contributor

bors bot commented Nov 1, 2022

Build succeeded:

@bors bors bot merged commit 6b2bbce into master Nov 1, 2022
@bors bors bot deleted the diralik/inline-function-Self branch November 1, 2022 16:14
@github-actions github-actions bot added this to the v183 milestone Nov 1, 2022
@neonaot neonaot self-assigned this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants