Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT: Don't offer Un-elide lifetimes intention when no input lifetimes #9741

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Nov 15, 2022

Fixes #9734

changelog: Don't offer Un-elide lifetimes intention when there is no input lifetimes

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Nov 15, 2022
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 15, 2022
9686: Parse rust path in short doc links r=vlad20012 a=dima74

Continuation of #7353

Now paths in short links are parsed as `RsPath`, and thus resolve and completion works for them. Note that short links can be either a path or a label, depending on the existence of the corresponding link definition for the label

```rust
/// [bar1] - direct link
/// [bar2] - markdown label reference
///
/// [bar2]: bar3
fn foo() {}
```

This together with #9688 will fix #6905

changelog: Support short [intra-doc links](https://doc.rust-lang.org/rustdoc/write-documentation/linking-to-items-by-name.html) (in format `[link]`)


9741: INT: Don't offer `Un-elide lifetimes` intention when no input lifetimes r=mchernyavsky a=dima74

Fixes #9734

changelog: Don't offer `Un-elide lifetimes` intention when there is no input lifetimes

Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Nov 15, 2022

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Nov 15, 2022

Build succeeded:

@bors bors bot merged commit 45b90aa into master Nov 15, 2022
@bors bors bot deleted the diralik/fix-unelide-lifetimes branch November 15, 2022 17:35
@github-actions github-actions bot added this to the v184 milestone Nov 15, 2022
@neonaot neonaot self-assigned this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Un-elide lifetimes' intention should not be available when nothing to un-elide
3 participants