feat: rate limit improvements #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## 5.x #1321 +/- ##
==========================================
- Coverage 47.72% 47.69% -0.03%
==========================================
Files 139 139
Lines 14282 14297 +15
==========================================
+ Hits 6816 6819 +3
- Misses 7466 7478 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
LordOfPolls
changed the title
|
This PR is complete, however due to its scope i request a review |
|
Tested working on my end, request someone else to confirm |
|
PR is needed and becoming stale. I've tested locally and will now merge |
LordOfPolls
added a commit
that referenced
this pull request
Apr 22, 2023
* feat: support regex component callbacks (#1332) * feat: support regex component callbacks * docs: document regex matching component callback * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: switch to MIT license (#1334) * chore: switch to MIT license * ci: correct from checks. * docs: update license through github Uses githubs own license tools so the correct license is detected --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: add audit events (#1335) * feat: add audit new mod events to audit log enum * feat: add onboarding related events see discord/discord-api-docs#6041 * refactor: change log level of missing value to warning (#1339) Lets not scare people with "error"s ay? * feat: add missing message types (#1338) * feat: add missing message types * feat: add deletable message types helper * build: correct manifest * feat: support avatar decorations (#1329) * build: mirrored publish to d.py-interactions and interactions.py (#1336) * style: add newline to end of manifest * ci: fix migration issues in integration test bot * fix: copy checks when inheriting (#1342) Co-authored-by: Astrea49 <25420078+Astrea49@users.noreply.github.com> * feat: cooldown upgrades (#1323) * docs: add changelog page * style: add EOF newline * docs: add 5.1.0 to changelog.md * style: remove trailing whitespace * fix: reintroduce imports at namespace linter removed * feat: sync improvements (#1328) * refactor: improve readability of sync logic * fix: improve initial sync caching * docs: add docstring to update_command_cache * feat: add command deletion to debug ext * feat: rate limit improvements (#1321) * fix: refactor all http routes to generate buckets properly * fix: resolve routes regex missed * feat: allow concurrent api calls from the same bucket * feat: restore bucketLock.locked property * feat: further bucketlock improvements * feat: allow bucketlock blocking to be toggled * refactor: resolve ruff compliant * fix: correct webhook http * fix: wrong check condition in the component callback (#1352) * fix: error when dispatch component callback (#1351) * docs: adjust and fix many parts of the docs (#1353) * docs: adjust and fix many parts of the docs * docs: add note about event object for v4 migration * docs: replace more instances of InteractionContext --------- Co-authored-by: Astrea49 <25420078+Astrea49@users.noreply.github.com> * feat: caching improvements (#1350) * feat: add support for force fetching * feat: track if a user object has been fetched * feat: add force flag to client helper methods * feat: update all cache fetch methods to have a force param * feat: add reset_with_key and get_cooldown_time_with_key (#1345) * made get_cooldown_with_key async for consistency, added reset_with_key and get_cooldown_time_with_key * ci: correct from checks. * fixed pre-commit problems * comment on #1345, resolved * made Cooldown.reset_all async #1345 * bot.load => bot.load_extension * reverted 8217f4e * made get_cooldown_time_with_key and reset_with_key sync --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> Co-authored-by: Astrea49 <25420078+Astrea49@users.noreply.github.com> Co-authored-by: Damego <damego.dev@gmail.com> Co-authored-by: chronosirius <73508925+chronosirius@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR rewrites all http methods to pass their params correctly, meaning rate limit buckets are properly generated and shared.
Additionally, this also rewrites the BucketLock to allow for concurrent requests to the API, rather than queuing them sequentially, improving HTTPClient throughput for large bots. Smaller bots are very unlikely to notice a difference.
Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.versionadded,versionchangedanddeprecatedto any new or changed user-facing function I committed.Pull-Request specification
I've made this pull request: (check all that apply)
This is: