Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add __eq__ to Snowflake #641

Merged
merged 2 commits into from Mar 14, 2022
Merged

feat: add __eq__ to Snowflake #641

merged 2 commits into from Mar 14, 2022

Conversation

Catalyst4222
Copy link
Contributor

About

This pull request adds the __eq__ magic method to the Snowflake model

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent): 622
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@i0bs i0bs enabled auto-merge (squash) March 13, 2022 23:34
i0bs
i0bs suggested changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove outdated comments. our choice on the existence of snowflake comparison seems pretty clear on how we use the paradigm in parallel to conditions.

interactions/api/models/misc.py Outdated Show resolved Hide resolved
interactions/api/models/misc.py Outdated Show resolved Hide resolved
interactions/api/models/misc.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled March 13, 2022 23:39

Head branch was pushed to by a user without write access

@i0bs i0bs enabled auto-merge (squash) March 14, 2022 14:53
@i0bs i0bs merged commit 63656b7 into interactions-py:unstable Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i0bs i0bs i0bs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
core
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Catalyst4222 @i0bs