Replace res.send( 404 ) with res.sendStatus( 404 ) in stream.js #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric79
requested review from
robertdhernandez,
davideaster,
landersk61,
youngca,
longtinm and
k-zaback
... which is the new way that node.js wants us to send a response that is empty other than the status code. (Sorry, I had introduced the deprecated version a little while ago)
youngca
force-pushed
the
replace-deprecated-send-with-sendStatus
branch
from
be3edb2
to
e01d235
Compare
youngca
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which is the new way that node.js wants us to send a response that is empty other than the status code. (Sorry, I had introduced the deprecated version a little while ago)