Strip Content-Type options for request #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if request.media_type && !empty_request?(request) | ||
| unless Rack::Mime.match?(request.media_type, @link.enc_type) | ||
| if request_media_type(request) && !empty_request?(request) | ||
| unless Rack::Mime.match?(request.media_type.to_s, @link.enc_type) |
There was a problem hiding this comment.
In the other pull we match against the split version of the media type, instead of the original. I think it would be good to do the same here. What do you think?
There was a problem hiding this comment.
sorry, it's very embarassing. I forgot to fix this line.
geemus
added a commit
that referenced
this pull request
Apr 28, 2015
Strip Content-Type options for request
|
Thanks! |
momosetkn
pushed a commit
to momosetkn/committee
that referenced
this pull request
Apr 8, 2023
matching in this context has the format of
```
['/user/{id}/edit', { 'id' => 1 }]
```
As the idea is to find matching path by minimum path params, the code should find min by the size of second element
momosetkn
pushed a commit
to momosetkn/committee
that referenced
this pull request
Apr 8, 2023
Find path by extracted params than path length, Close interagent#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(refs. #70)
Hi, some http clients always set Content-Type options for request, such as "application/json; charset=UTF-8".
This PR strip Content-Type options like PR#70 above.
BR,
dlwr