Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics middleware #289

Merged
merged 2 commits into from
Dec 9, 2016
Merged

Conversation

joshwlewis
Copy link
Contributor

This adds a new middleware that is extracted from the operational patterns we rely on for our Ruby apps at Heroku. It sends a basic, minimal number of request metrics to the configured backend provider. These metrics should allow an operator to get a basic idea of:

  1. How many requests the app is processing
  2. The breakdown of statuses the app is responding with
  3. The overall request latency for the app

I've added this as an independent middleware so that apps can opt out of the functionality if desired.

@pedro
Copy link

pedro commented Dec 8, 2016

very cool! 👍

@brandur
Copy link
Member

brandur commented Dec 8, 2016

Love it! Really nice job on the tests too. +1.

@gudmundur gudmundur merged commit bcacd02 into interagent:master Dec 9, 2016
@gudmundur
Copy link
Member

I wouldn't mind seeing this as a default in routes.rb. If people don't want this, they can easily opt out. It also helps with discovery of this feature. Yum yum.

@joshwlewis
Copy link
Contributor Author

Hmm, it is in routes.rb. Shouldn't that make it the default?

@joshwlewis joshwlewis deleted the request-metrics branch December 9, 2016 19:36
@gudmundur
Copy link
Member

Lol. Totally missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants