LPS-113189 Hiding sidebar title when a field is selected #87
Conversation
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
| @@ -45,6 +45,14 @@ | |||
| } | |||
| } | |||
|
|
|||
| .hide-title.sidebar-header { | |||
There was a problem hiding this comment.
Rebeca, para ficar mais legivel, podemos renomear esta classe hide-title para display-settings?
| @@ -33,7 +33,7 @@ export default function ({title}) { | |||
|
|
|||
| return ( | |||
| <Sidebar> | |||
| <Sidebar.Header> | |||
| <Sidebar.Header className={displaySettings ? 'hide-title' : ''}> | |||
There was a problem hiding this comment.
Se sim, teremos que renomear aqui tbm, de hide-title para display-settings
There was a problem hiding this comment.
Por fim, esqueci de te passar um método que usamos para adicionar classes quando usamos condições.
No caso, ficaria assim:
import 'className' from 'classnames';
className({'display-settings': displaySettings})
Dessa forma, não irá renderizar '' no HTML renderizado.
There was a problem hiding this comment.
certo, vou fazer as alterações!
| @@ -33,7 +33,7 @@ export default function ({title}) { | |||
|
|
|||
| return ( | |||
| <Sidebar> | |||
There was a problem hiding this comment.
Se adicionarmos a classe display-settings na tag Sidebar, isso poderá ser usado futuramente não só para ajustar o header como qualquer lugar da sidebar
|
LGTM |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-113189 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6216 |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#8692 |
|
ci:test:stable |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#3136 |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#89650 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6201 |
No description provided.