chore: demote sinon to dev dependencies

[vkarpov15]

Sinon doesn't need to be a prod dependency, the only place you use it is here: https://github.com/intercom/intercom-node/blob/4bd04979a0a0ba962d0f396fba9bf4c39f2ebefd/test/user-data.js

[jpike88]

I really would prefer installation without this donation message too.

sinonjs/sinon#1737

[jpike88]

@jonnyom this is such a minor, fast pr to accept. Can you please just let it through?

[jpike88]

@vkarpov15 actually could you amend this PR to an updated version of sinon? They deleted that annoying as hell donation message, it's incredibly grating to see that love heart appearing in all my build logs.

[jonnyom]

Hey @jpike88 and @vkarpov15 thanks for this.

Happy to approve this, I can't see any reason for that to be in the production dependencies.

@vkarpov15 as Josh mentioned, could you please update to the latest version of Sinon? Be happy to approve then.

Thanks a million 👍

[vkarpov15]

@jonnyom done.

[jpike88]

@jonnyom just confirming that the donation message issue is fixed

[jonnyom]

LGTM. 👍 will look into getting a release set up for this ASAP

[jpike88]

@jonnyom whats our ETA on approving this? I'm getting triggered constantly in my build logs

[jonnyom]

@jpike88 - we identified an issue with CI not building forked repos, which is where the delay came from here. We should have this updated and released to a new version by next week.

Thanks for the patience on this one.