Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postinstall script log asking for donations? #1737

Closed
SimonSchick opened this issue Mar 15, 2018 · 8 comments
Closed

Postinstall script log asking for donations? #1737

SimonSchick opened this issue Mar 15, 2018 · 8 comments

Comments

@SimonSchick
Copy link

So this is not strictly about sinon functionality therefor I am not going to use the template.

I have never seen a package actively ask for donations via a postinstall script, this is not exactly malicious but I don't think this is appropriate use of postinstall either as it also unnecessarily slows down installs...

@mantoni
Copy link
Member

mantoni commented Mar 15, 2018

It slows down your install time by something like a few milliseconds. We think that’s totally reasonable. We‘re not the only ones doing this. We also ask for donations on our website and in the readme.

@mantoni mantoni closed this as completed Mar 15, 2018
@billyjanitsch
Copy link

billyjanitsch commented Mar 20, 2018

@mantoni I empathize with the motivation to introduce the postinstall message: y'all deserve to be compensated for the time you spend on the project, and I appreciate the need to find ways to ask users to contribute.

However I'm not sure the impact is as low as you think, especially when you consider scaling. A typical npm tree contains thousands of packages. What if many packages start doing this?

I timed the postinstall script at ~80ms (starting a node process isn't free), which is negligible on its own, but it would only take 10 packages doing this to add ~1s to every local and CI install.

More importantly, npm install currently produces a useful log of lifecycle scripts and a tree summary. Even if only sinon's 14 (incl. transitive) dependencies included similar messages, sinon's own message would be lost in the noise -- defeating the purpose of it -- and it would be way less clear to users what actually happened in the lifecycle stage.

So I feel like this kind of solution, at best, only works briefly for the first few packages that do it, and then results in a worse ecosystem overall. To be clear, I'm not saying that you should work for free, and I'm happy that OSS revenue solutions are starting to pop up (npx thanks, Open Collective, etc.) I just don't think a postinstall script is a good medium. I understand if you disagree. ❤️

@mroderick
Copy link
Member

The postinstall script was implemented by me as an experiment to try to drive more donations to our Open Collective.

It’s inspired by (imitating) Remy’s strategy for nodemon: https://remysharp.com/2018/01/10/open-source-with-a-cap-in-hand

So far, I am still about €500 out of pocket to pay the costs of bringing the stewards together for the first time, in order to get sinon@2 released. That was a year ago and has changed how we work on Sinon and related projects.

Once we have accelerated the community support, then I am happy to remove it again.

Other strategies to help pay for our (minimal) costs would be most welcome.

@ljharb
Copy link
Contributor

ljharb commented Mar 21, 2018

I truly do appreciate that you need funding, but polluting the install logs of all consumers with an advertisement really isn't a great way to generate empathy and incentivize donations.

@fatso83
Copy link
Contributor

fatso83 commented Mar 21, 2018

Objections noted, but I think the view of the core team is pretty aligned with regards to pros/cons. We should revise our position in six months time, though. This isn't a biggie.

@deyhle
Copy link

deyhle commented Apr 17, 2018

I fully understand that you're looking for donations, but I strongly agree with @SimonSchick , @billyjanitsch and @ljharb that a postinstall script is the wrong way to advertise this, mainly because log pollution is damaging the ecosystem as whole. npm/node is no longer a playground for a small tech bubble, but an ecosystem used in production at large scale. Looking forward to removal of the message once you reach your funding goal.

@mroderick
Copy link
Member

Looking forward to removal of the message once you reach your funding goal

I think we all are

@mantoni
Copy link
Member

mantoni commented Jul 26, 2018

@jpike88 It has already been removed 6 weeks ago in 8f34417. Thank you for your your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants