Add script to vendor/bin folder #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unserialization can produce syntax errors, which are under Error in the php exception hierarchy.
|
Hello, thanks for the PR! Is this going to work since that file expects the class in the same directory? https://github.com/interconnectit/Search-Replace-DB/blob/master/srdb.cli.php#L32 |
|
Yes, it seems to work for me. Composer doesn't copy the file, it just puts a symlink into the vendor/bin folder. Then the require_once() in srdb.cli.php will find the other class since symlinks in __FILE__ are resolved. I'm not sure what composer does on platforms without symlinks, however. |
|
good point! We need a test on windows 😃 |
|
Per the composer docs, on windows it creates a .bat file instead of a symlink: https://getcomposer.org/doc/articles/vendor-binaries.md#what-about-windows-and-bat-files- |
gianluigi-icit
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects adding Search-Replace-DB as a dependency, composer will now symlink the script into the bin folder.