Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print ss58 encoded addresses by network #271

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

gregdhill
Copy link
Member

@gregdhill gregdhill commented Mar 31, 2022

Signed-off-by: Gregory Hill gregorydhill@outlook.com

We could fetch this parameter from the metadata but then it would become very involved to pass the value.

Copy link
Member

@sander2 sander2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! But we should try to use it consistently. You missed a couple of cases (e.g. theExecuting issue #{:?} on behalf of user {:?} with vault {:?})

@gregdhill
Copy link
Member Author

Good change! But we should try to use it consistently. You missed a couple of cases (e.g. theExecuting issue #{:?} on behalf of user {:?} with vault {:?})

I think those already call pretty_printed() right?

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
@sander2
Copy link
Member

sander2 commented Apr 19, 2022

Good change! But we should try to use it consistently. You missed a couple of cases (e.g. theExecuting issue #{:?} on behalf of user {:?} with vault {:?})

I think those already call pretty_printed() right?

Vault ids are pretty printed, yes, but misc account ids are not. In the example I gave, issue.requester would be printed with a differently encoded network

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
@gregdhill gregdhill merged commit e408444 into interlay:master Apr 20, 2022
@gregdhill gregdhill deleted the feat/ss58-prefix branch April 20, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants